feat: show settings UI to toggle QuickOpen hotkeys #179

The quickOpen.isEnabled setting was already externalized out to data.json #124. This change just adds a new toggle Setting to generalSettingsTabSection to make quickOpen.isEnabled visible in the settings UI.

src/settings/__tests__/generalSettingsTabSection.test.ts

@@ -537,6 +537,45 @@ describe('generalSettingsTabSection', () => {
       config.renderMarkdownContentInSuggestions.renderHeadings = false;
       addToggleSettingSpy.mockReset();
     });
+
+    describe('showQuickOpen', () => {
+      type addToggleSettingArgs = Parameters<SettingsTabSection['addToggleSetting']>;
+      let toggleSettingOnChangeFn: addToggleSettingArgs[5];
+      let saveSettingsSpy: jest.SpyInstance;
+
+      beforeAll(() => {
+        saveSettingsSpy = jest.spyOn(config, 'saveSettings');
+      });
+
+      afterAll(() => {
+        saveSettingsSpy.mockRestore();
+      });
+
+      it('should save changes to the enable QuickOpen setting', () => {
+        const initialValue = false;
+        const finalValue = true;
+
+        config.quickOpen.isEnabled = initialValue;
+        addToggleSettingSpy.mockImplementation((...args: addToggleSettingArgs) => {
+          if (args[1] === 'Enable quick open hotkeys for top results') {
+            toggleSettingOnChangeFn = args[5];
+          }
+
+          return mock<Setting>();
+        });
+
+        sut.showQuickOpen(mockContainerEl, config);
+
+        // trigger the change/save
+        toggleSettingOnChangeFn(finalValue, config);
+
+        expect(saveSettingsSpy).toHaveBeenCalled();
+        expect(config.quickOpen.isEnabled).toBe(finalValue);
+
+        config.quickOpen.isEnabled = false;
+        addToggleSettingSpy.mockReset();
+      });
+    });
   });
 
   describe('showInsertLinkInEditor', () => {

src/settings/generalSettingsTabSection.ts

@@ -89,6 +89,7 @@ export class GeneralSettingsTabSection extends SettingsTabSection {
 
     this.showResetFacetEachSession(containerEl, config);
     this.showRenderMarkdownContentAsHTML(containerEl, config);
+    this.showQuickOpen(containerEl, config);
   }
 
   showPreferredSourceForTitle(
@@ -354,4 +355,18 @@ export class GeneralSettingsTabSection extends SettingsTabSection {
     );
     setting.setClass('qsp-setting-item-indent');
   }
+
+  showQuickOpen(containerEl: HTMLElement, config: SwitcherPlusSettings): void {
+    this.addToggleSetting(
+      containerEl,
+      'Enable quick open hotkeys for top results',
+      'When enabled, hotkeys will be defined for each of the top N results displayed in the Switcher. These hotkeys can be used to quickly open the associated suggestion directly. when disabled, no hotkeys are defined.',
+      config.quickOpen.isEnabled,
+      null,
+      (value, config) => {
+        config.quickOpen.isEnabled = value;
+        config.save();
+      },
+    );
+  }
 }