Hasselblad CFV-50c alias cleanup #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `id` is what gets shown in dt UI, we only want one model for all body combos Hasselblad Phocus software also normalizes to just "Hasselblad CFV-50c" when converting any of these from 3FR to FFF
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #650 +/- ##
========================================
Coverage 60.95% 60.95%
========================================
Files 267 267
Lines 15967 15967
Branches 2047 2047
========================================
Hits 9732 9732
Misses 6104 6104
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
I guess this makes sense. This is so horrible :) @kmilos thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idattribute is what gets shown in dt UI (if present and different from the actual value), we only want one model for all body combos.Hasselblad Phocus software also normalizes to just "Hasselblad CFV-50c" when converting any of these from 3FR to FFF.