-
Notifications
You must be signed in to change notification settings - Fork 99
Update as shot to reference documentation #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update as shot to reference documentation #789
Conversation
| : - _camera reference_: Set the temperature to the camera reference white point, which is assumed to be D65 (or ~6502K). The white balance channel multipliers are calculated such that pure white in the camera colorspace is converted into pure white in sRGB D65 (where pure white means that each color channel has an equal value). | ||
|
|
||
| For convenience the final four modes can also be set by clicking on one of the buttons in the [button bar](#button-bar) above the _setting_ drop-down. | ||
| : - _as shot to reference_: (default) The white balance as reported by the camera is used in processing modules before _colorin_ for slightly better results in [_highlights reconstruction_](./highlight-reconstruction.md), [_raw chromatic aberrations_](./raw-chromatic-aberrations.md), [_demosaic_](./demosaic.md) or [_denoise profiled_](./denoise-profiled.md). This is correcter later in the pipe in [_colorin_](./colorin.md) to the camera reference white point as in _camera reference_. Please note: In a few cases the coefficients reported by the camera for 'as shot' are bad so you might prefer _camera reference_ in those cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You make reference to the colorin documentation here. I assume you mean input color profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You make reference to the colorin documentation here. I assume you mean input color profile?
I was intentionally referring to colorin as thats the place in the pipe where the data are finally corrected to D65. Thats the only difference compared to 'camera reference'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'm just saying that no user will no what "colorin" mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will they know what a profile is? :-) I just take your word on this ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but they can look at the documentation for input color profile if you give them the correct link
|
Please can you add a link to the relevant PR so I can update the labels once it's merged |
|
#15602 is the one with pending docs |
Has been pending "for ages"