Skip to content

Conversation

@dterrahe
Copy link
Member

@dterrahe dterrahe commented Sep 23, 2025

And, more importantly maybe, rejigged some of the ways shortcuts and actions are set up internally to make this process less error prone.

Based on discussion on #19407

EDIT: added back the optimisation to not fill comboboxes with their individual items when we are just temporarily initialising iops in order to harvest their actions available to shortcuts.

Also factored out some curve interpolation method combos, so they now have introspection in shortcuts (you can directly trigger a specific item).

Changing to non-draft to get some more feedback on the included default shortcuts

@dterrahe dterrahe added priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions scope: codebase making darktable source code easier to manage labels Sep 23, 2025
@dterrahe dterrahe marked this pull request as ready for review September 24, 2025 09:26
@TurboGit TurboGit added this to the 5.4 milestone Sep 24, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit merged commit 3525170 into darktable-org:master Sep 24, 2025
5 checks passed
@ralfbrown
Copy link
Collaborator

Release notes

UI/UX improvements

  • Added new default shortcut keys. These will take effect only if the keys do not yet have user-defined assignments.
    • c - toggle crop box
    • e - set exposure compensation (equivalent to right-clicking on the exposure slider)
    • alt-r - set image rotation (equivalent to right-clicking on the rotation slider)
    • alt-[ and alt-] - fine rotation adjustment

Diederik can chime in on which of the internal improvements should be mentioned, presumably in the "other changes" section.

@dterrahe
Copy link
Member Author

The internal changes are just to make my and your lives easier. Nothing the user would notice.

And some OCD on interpolation methods, for the one lunatic who wanted a shortcut to set a specific value (or, maybe more relevant, set it from Lua). Whoever needs it and is into shortcuts will find it.

But you forgot to mention that Ctrl+, is now also enabled on non-Apple platforms to get Preferences.

And it might be worth reminding those avid readers of the release nodes that

  • Enabling Fallbacks (in the shortcuts dialog) will give you e+scroll to directly adjust exposure (and e+horizontal mouse move for fine tuning and e+vertical for big steps) for free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low core features work as expected, only secondary/optional features don't scope: codebase making darktable source code easier to manage scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants