implement callback for GtkDarktableResetLabel #17161
Conversation
- border color - frame line color fixed a few bugs with the default color assignments.
|
@zisoft Tested, it works! Huge thanks for the quick fix! This is the case when I had to only raise an issue because I didn't have the stamina to look for the bug myself. We had many 35-36° days without air conditioning due to power shortage (all our thermal generation destroyed). So my brains were in thermal throttling mode. 🥵 |
|
@victoryforce Thank you Victor! Let's all hope that this stupid war finally comes to an ending. |
@zisoft Unfortunately, the vast majority of Russians support the genocide of the Ukrainians, and their leader, Putin, has no intention of stopping despite the terrible losses of the Russian army, so the only way to end this war is to defeat them. Restrictions on the use of Western weapons only prolong the war, thus increasing the number of both our victims (soldiers and civilians) and victims among Russian cannon fodder. Undefeated Russia, which will be forgiven for the partial occupation of Ukraine, will rearm and try to destroy Ukraine with even greater ferocity at the first opportunity. A peaceful agreement is impossible: they do not want to give up the subjugation of Ukraine, we cannot stop resistance if we want to live. |
fixes darktable-org#17157 by correctly linking the reset to the live parameters, rather than the default ones (or rather overwriting some random memory location). Bug introduced in darktable-org#6240 four years ago. _frame_ color reset may never have worked. alignment reset needs gui->reset, so call dt_iop_gui_update rather than module->gui_update directly. Also add (translatable) descriptions for (frame) color fields that will be used in the history changes tooltip. simpler alternative to darktable-org#17161 that fixes the real issue.
fixes darktable-org#17157 by correctly linking the reset to the live parameters, rather than the default ones (or rather overwriting some random memory location). Bug introduced in darktable-org#6240 four years ago. _frame_ color reset may never have worked. alignment reset needs gui->reset, so call dt_iop_gui_update rather than module->gui_update directly. add check that would have caught this condition earlier. Also add (translatable) descriptions for (frame) color fields that will be used in the history changes tooltip. simpler alternative to darktable-org#17161 that fixes the real issue.
zisoft
added
bugfix
|
Release notes: Fixed a bug where double clicking on a label in darkroom modules does not reset the control. |
|
Thanks! |
fixes #17157
The problem here is that
_reset_label_callback()resets the module parameters to its default values, but the according GUI element needs to be reset as well. So I have implemented a callback function for the GtkDarktableResetLabel to accomplish this.The commits are per module for easier reverts if something went wrong.