Fix pixelpipe extensive work while exporting #16840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how it should be done depending on "high-quality" (HQ) and "upscale" UP HQ=OFF UP=OFF the final size is achieved by down-scaling in demosaic, we never upscale. (was good) HQ=ON UP=OFF the pixelpipe processes all avaible data, the output size is achieved in the finalscale module and is never upscaled (was good) HQ=ON UP=ON the pixelpipe processes all avaible data, the output size is achieved in the finalscale module and may be increased by upscaling (was good) HQ=OFF UP=ON as uscaling is allowed this should behave exactly as HQ=ON/UP=ON Until now we **upscaled** in the demosaicer to full size leading to excessive cpu/gpu load possibly with heavy tiling achieving nothing or even likely reducing quality. If we export with "high quality"=ON and "upscale=OFF the pixelpipe should process all data and finally down/upscale in finalscale. If we toggle on "upscale"
ralfbrown
added
bugfix
|
Release note: Fixed export processing if a) high quality was off and b) upscale was on. |
TurboGit
added
the
priority: high
|
@elstoc we might want to describe this in the manual |
jenshannoschwalm
added
the
documentation-pending
|
@elstoc another one that doesn't really change anything (documentation wise) but gives a better result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it should be done depending on "high-quality" (HQ) and "upscale" UP
HQ=OFF UP=OFF
the final size is achieved by down-scaling in demosaic, we never upscale. (was good)
HQ=ON UP=OFF
the pixelpipe processes all available data, the output size is achieved in the finalscale
module and is never upscaled (was good)
HQ=ON UP=ON
the pixelpipe processes all available data, the output size is achieved in the finalscale
module and may be increased by upscaling (was good)
HQ=OFF UP=ON
as upscaling is allowed this should behave exactly as HQ=ON/UP=ON
Until now we upscaled in the demosaicer to full output size leading to excessive cpu/gpu load
possibly with heavy tiling achieving nothing or even likely reducing quality.