Highlights raster mask #16575
Merged
Highlights raster mask #16575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
feature: new
TurboGit
added
priority: low
jenshannoschwalm
added
the
bug: wip
jenshannoschwalm
force-pushed
the
highlights_raster
branch
from
dadfd4a to
5daf6a1
Compare
TurboGit
requested changes
Apr 7, 2024
Make highlight "reconstruction" data available as a raster mask to be used at other parts of the pipeline. The mask used in highlight module - uniform or drawn - is modified by the process ratio of output and input data of that module. Works with all hightlights algorithms. Mask is gaussian-blurred for less noise.
jenshannoschwalm
force-pushed
the
highlights_raster
branch
from
5daf6a1 to
f94f976
Compare
|
fixes as requested, squashed and force-pushed. Comments: masking in pre-demosaic modules is broken for non-raws atm. Was also in master, will fix in another PR. |
Ah, didn't notice that. Is that since a long time? |
|
I simply don't know. I think we oversaw the colorspace default in one of the earlier modules in the pipe. Likely there was simply noone using masks in those modules on sraws. I just stumbled across this by chance. |
|
Reproducer: use an sraw file, define any mask in highlights, use -d pipe. Module csp is RAW for all modules early in the pipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the problem "What can we do with remaining color casts?".
Instead of
This PR offers a simple raster mask generation of the highlights module. It works for all internal algorithms that increase clipped photosite channels like opposed, segmentation based or laplacian. Respects the used mask in HLR module and modifies it.
To check: