Remove deprecated properties. #15898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you see a diff on the UI it would be nice to have some screenshots. Easier for everyone to understand the actual change. TIA. |
I will keep that in mind for the next time. Thanks. |
I tested this PR on macOS and Windows and I cannot see any difference in the checkboxes. |
|
In order to make the whole migration inside a single branch, close this one and merge the branch Christian-Kr:krippendorf/gtk4_prepare_001 into Christian-Kr:krippendorf/gtk4. This PR is not needed anymore. Greetings |
|
@Christian-Kr : Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
both properties are deprecated. I just removed them, or replaced them with other methods. The only thing I see as a result, is the bigger checkbox here on a high definition display. I would say, they now have the right size, like the other checkboxes. I cannot test how this looks on different displays or scales.
Maybe someone else can test this code.
Thanks in advance.
Greetings