Checkmark in a menu item will still be visible after hovering mouse over an item #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a screenshot with this fix in place. The checkmark is now visible even when mouse is hovered over the menu item because the checkmark color gets inverted just like the text does so that it is black on white instead of white on white.
This is how it looks in Helium right now:
This is how it looks with my change:
Ignore the fact that my screenshot shows the menu item highlighting taking the full width of the menu item. That is simply because I have forked Helium and made some other style changes. But I thought the change in this PR about making sure the checkmark is visible might be something you would want to take because it feels like a bug and less so a subjective styling choice.