fix for #12 #14
Merged
fix for #12 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (verbose) console.log('`' + children[i].cmd + '` will now be closed'); | ||
| } | ||
| } | ||
| process.exit(); |
There was a problem hiding this comment.
There is a breaking change here. Before, parallelshell would exit with a non-zero exit code if the child process did, now it does not. This close function should ideally find the first non-zero exit code and exit with that (or if all exit codes are 0, of course, then exit with that).
Simply refactor this function as follows:
function close () {
var code = 0;
for (var i = 0, len = children.length; i < len; i++) {
if (!children[i].exitCode) {
children[i].removeAllListeners('close');
children[i].kill('SIGINT');
if (verbose) console.log('`' + children[i].cmd + '` will now be closed');
} else {
code = children[i].exitCode;
}
}
process.exit(code);
}
|
Great work @paulpflug! I've made a couple of comments above that I'd like to see addressed, then I'm happy to merge 😄 |
|
I did work it in + added a proper unit test |
|
Nice work 😄 |
keithamus
added a commit
that referenced
this pull request
May 5, 2015
estk
pushed a commit
to estk/parallelshell
that referenced
this pull request
Sep 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed alot. pls review!
#12