Compute mandatory populate and filter collections when reassigning results #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running it for each dataloaderFind we now run it once for each queryMap. We dont add any more overhead to getNewFiltersAndMapKeys but now we have to fully traverse newFilter one additional time just to compute the mandatory populate options.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 59.37% 53.84% -5.53%
==========================================
Files 2 2
Lines 192 247 +55
Branches 60 88 +28
==========================================
+ Hits 114 133 +19
- Misses 66 93 +27
- Partials 12 21 +9 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.