Add advertisingSid property to ScanResult
#856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KrzysztofMamak
changed the title
ScanResultadvertisingSid property to ScanResult
KrzysztofMamak
force-pushed
the
add-advertising-sid-property
branch
3 times, most recently
from
09f839a
to
f1d6582
Compare
KrzysztofMamak
force-pushed
the
add-advertising-sid-property
branch
from
f1d6582
to
5f56031
Compare
|
Hey, thanks for doing this. FYI I'm currently on holiday till the end of the first week of August and most probably won't be able to review earlier. |
...roidble/src/main/java/com/polidea/rxandroidble2/internal/scan/InternalScanResultCreator.java
Outdated
Show resolved
Hide resolved
rxandroidble/src/main/java/com/polidea/rxandroidble2/scan/ScanResult.java
Outdated
Show resolved
Hide resolved
|
@dariuszseweryn hey! Do you plan on releasing a version with that addition soon? :) |
|
As soon as possible. I seem to have a problem with recent configuration changes on Sonatype which prevent me from uploading an artifact. I'll need to reach their support probably |
|
1.19.0 should be available shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
advertisingSidproperty toScanResult.Fixes #854