-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 7 #763
base: master
Are you sure you want to change the base?
Gradle 7 #763
Conversation
# Conflicts: # mockrxandroidble/build.gradle # rxandroidble/build.gradle # sample-kotlin/build.gradle # sample/build.gradle
Seems to work without now, and errors with
After merging the unit tests without robolectric, all tests are passing now. The only remaining work to do is testing maven publish which I don't think I can do. |
@dariuszseweryn Building javadocs currently doesn't work because of relocated javax.inject:
I upgraded the shadow plugin but still get the same error. Any ideas? |
@dariuszseweryn I decided to fork this project so we can maintain it more actively and merge the PRs we had open. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. I've merged this PR there. If you continue maintaining this project, you may want to look at the following files for up to date publishing to Maven Central via GitHub Action: |
I had a go at switching to gradle 7.
One issue is Maven publishing. I switched to the maven-publish plugin, but not sure I can test it. I wasn't sure how to handle non-android libraries either so I excluded for now. Perhaps a starting point though.
Some unit tests fail. When running the tests in Android studio, I get a lot of
java.lang.reflect.InvocationTargetException
in ElectricSputnik, but this doesn't occur when running in the GitHub action. I'm not sure what the difference is, any ideas?Otherwise, the sample App builds and runs fine.