Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StateManager to use the new client. #101

Merged
merged 15 commits into from
Jul 17, 2021
Merged

Conversation

withinboredom
Copy link
Contributor

@withinboredom withinboredom commented Jul 16, 2021

Description

Transparently replace the StateManager with a new class that uses the new client.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue this PR: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #101 (0dc2156) into main (f87e3d3) will increase coverage by 0.53%.
The diff coverage is 57.18%.

❗ Current head 0dc2156 differs from pull request most recent head f529e42. Consider uploading reports for the commit f529e42 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #101      +/-   ##
============================================
+ Coverage     68.17%   68.71%   +0.53%     
- Complexity      458      494      +36     
============================================
  Files            59       63       +4     
  Lines          1697     1819     +122     
============================================
+ Hits           1157     1250      +93     
- Misses          540      569      +29     
Impacted Files Coverage Δ
src/index.php 0.00% <0.00%> (ø)
src/lib/Client/DaprClient.php 53.84% <ø> (ø)
src/lib/Client/DaprHttpClient.php 84.61% <ø> (ø)
src/lib/Client/HttpInvokeTrait.php 0.00% <0.00%> (ø)
src/lib/State/StateManagerOld.php 0.00% <0.00%> (ø)
src/lib/State/TransactionalStateOld.php 0.00% <0.00%> (ø)
src/lib/State/TransactionalState.php 92.06% <92.06%> (-2.39%) ⬇️
src/lib/State/StateManager.php 98.21% <98.21%> (+1.44%) ⬆️
src/config.php 100.00% <100.00%> (ø)
src/lib/Client/DeleteTransactionRequest.php 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87e3d3...f529e42. Read the comment docs.

@withinboredom withinboredom merged commit 5e2e0b4 into main Jul 17, 2021
@withinboredom withinboredom deleted the refactor/state branch July 17, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants