Skip to content

Auto-validation for tracing sample. #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

artursouza
Copy link
Contributor

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #469

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza force-pushed the tracing_example_validate branch 2 times, most recently from ab742af to 887a529 Compare March 11, 2021 07:50
@artursouza artursouza force-pushed the tracing_example_validate branch from 887a529 to 157d5be Compare March 11, 2021 07:59
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #508 (5f379f2) into master (1eff655) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #508      +/-   ##
============================================
- Coverage     80.43%   80.29%   -0.14%     
+ Complexity      974      973       -1     
============================================
  Files            88       88              
  Lines          3015     3015              
  Branches        330      330              
============================================
- Hits           2425     2421       -4     
- Misses          424      427       +3     
- Partials        166      167       +1     
Impacted Files Coverage Δ Complexity Δ
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <0.00%> (-25.00%) 1.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eff655...5f379f2. Read the comment docs.

Copy link
Contributor

@wcs1only wcs1only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit dcaffe8 into dapr:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto validation for Tracing Example
2 participants