Skip to content

feat: Support for GRPC ssl #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented May 14, 2025

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1353

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

javier-aliaga and others added 2 commits May 14, 2025 17:40
@famarting
Copy link

famarting commented May 14, 2025

this adds client cert and key, which I think is for MTLs

can we add another option to just set a CA, i.e if you were going to just expose tls with selfsigned certs, so we can still use tls

@salaboy
Copy link
Collaborator

salaboy commented May 14, 2025

this adds client cert and key, which I think is for MTLs

can we add another option to just set a CA, i.e if you were going to just expose tls with selfsigned certs, so we can still use tls

We were looking at the code described in this issue: #1353

@salaboy
Copy link
Collaborator

salaboy commented May 14, 2025

I am looking at the APIS available now to see what else can be set.

@salaboy
Copy link
Collaborator

salaboy commented May 14, 2025

I am looking at the APIs it looks like we just need to set: trustManager()

 ChannelCredentials credentials = TlsChannelCredentials.newBuilder()
                .trustManager()
                .build();

This answer kinda makes sense to me, it will be great to validate that we are understanding the same @famarting -> https://stackoverflow.com/questions/76339586/grpc-java-enable-tls-encryption-without-using-ca-certificate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL CA support for the Java SDK
4 participants