feat: Add taskExecutionId field #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-aliaga
force-pushed
the
javi-add-activity-execution-id
branch
from
2fff5c0 to
dc81024
Compare
JoshVanL
requested changes
Jun 16, 2025
| @@ -24,6 +24,7 @@ message ActivityRequest { | |||
| OrchestrationInstance orchestrationInstance = 4; | |||
| int32 taskId = 5; | |||
| TraceContext parentTraceContext = 6; | |||
| string taskExecutionId = 7; | |||
There was a problem hiding this comment.
What value is to be expected here and by who?
There was a problem hiding this comment.
this value is used to propagate the taskExecutionId from the scheduled task to the worker to build the context
https://github.com/dapr/durabletask-go/blob/28ab9ebfa7bb2f1d6d0237b5d2ce60b6be712e2b/backend/executor.go#L161 and https://github.com/dapr/durabletask-go/blob/28ab9ebfa7bb2f1d6d0237b5d2ce60b6be712e2b/client/worker_grpc.go#L187
4 tasks
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
javi-add-activity-execution-id
branch
from
ae268b0 to
b9c1975
Compare
javier-aliaga
changed the title
javier-aliaga
force-pushed
the
javi-add-activity-execution-id
branch
from
b9c1975 to
ecfd5c8
Compare
This was referenced Jun 20, 2025
acroca
approved these changes
Jun 20, 2025
cicoyle
approved these changes
Jun 23, 2025
JoshVanL
approved these changes
Jun 30, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
taskExecutionIdto provide a unique identifier for task executions. ThetaskExecutionIdwill remain the same between retries but will be different on reruns.The field has been added to:
ActivityRequestTaskScheduledEventTaskCompletedEventTaskFailedEventScheduleTaskActionValue is not optional but defaults to empty.
This pr is part of this proposal