Repository navigation
Do not send binary gRPC metadata on InvokeBinding calls - #1901
Merged
WhitWaldo merged 1 commit intoAug 25, 2026
Merged
Conversation
Strip -bin suffixed gRPC metadata from InvokeBinding call options before sending. Trace context still propagates via the traceparent and tracestate text headers, and all other APIs keep sending grpc-trace-bin. This is a client-side mitigation for runtimes without the fix from dapr/dapr#10387. Fixes dapr#1897 Signed-off-by: joshvanl <me@joshvanl.dev>
WhitWaldo
approved these changes
Aug 25, 2026
WhitWaldo
left a comment
WhitWaldo
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - thank you!
2 of 3 tasks
WhitWaldo
reviewed
Aug 25, 2026
|
|
||
| for (var i = headers.Count - 1; i >= 0; i--) | ||
| { | ||
| if (headers[i].Key.EndsWith("-bin", StringComparison.OrdinalIgnoreCase)) |
Contributor
Contributor
Author
There was a problem hiding this comment.
@WhitWaldo no I think keeping the -bin is correct:
https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
Note that HTTP2 does not allow arbitrary octet sequences for header values so binary header values must be encoded using Base64 as per https://tools.ietf.org/html/rfc4648#section-4. Implementations MUST accept padded and un-padded values and should emit un-padded values. Applications define binary headers by having their names end with "-bin". Runtime libraries use this suffix to detect binary headers and properly apply base64 encoding & decoding as headers are sent and received.
x-ms-meta-daprgrpctracebin is not a proper gRPC binary header AFAIK
This was referenced Sep 27, 2026
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip -bin suffixed gRPC metadata from InvokeBinding call options before sending. Trace context still propagates via the traceparent and tracestate text headers, and all other APIs keep sending grpc-trace-bin. This is a client-side mitigation for runtimes without the fix from dapr/dapr#10387.
Fixes #1897