Added OTEL envvar for service name overriding in traces #3971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
hhunter-ms
added
the
waiting-on-code-pr
…ame can be overridden in OTEL traces. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Contributor
Author
|
@hhunter-ms Just a ping to confirm that the associated code has been merged into 1.14 |
hhunter-ms
removed
the
waiting-on-code-pr
|
Stale PR, paging all reviewers |
Contributor
|
Congratulations @WhitWaldo, you just earned a badge! Here it is: https://holopin.io/claim/clvwfw4hx116240fl7v4rdsxwx This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added a line to the list of tracing environment variables to indicate the key from which the OTEL service name can be specified instead of Dapr using the default ID from the runtime configuration.
Issue reference
Code PR: dapr/dapr#7451
Issue: dapr/dapr#5942 (though it's already closed for staleness, it was never remedied, so this will also solve Aspire tracing integration at dotnet/aspire#1228