Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix helm value for prometheus #3325

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix helm value for prometheus #3325

merged 1 commit into from
Apr 12, 2023

Conversation

owenchenxy
Copy link
Contributor

correct the value for setting Persistent Volume for alertmanager

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

#3324

@owenchenxy
fix helm value for prometheus
0f79c13 
correct the value for setting Persistent Volume for alertmanager

Signed-off-by: Xianyao Chen <owenchenxy@gmail.com>
@owenchenxy owenchenxy requested review from a team as code owners April 6, 2023 01:41
@owenchenxy owenchenxy mentioned this pull request Apr 6, 2023
Closed
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 12, 2023
@msfussell msfussell removed the stale label Apr 12, 2023
@msfussell msfussell added this to the 1.10 milestone Apr 12, 2023
msfussell
msfussell approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for spotting this! Appreciate the PR

@msfussell msfussell merged commit 393e88f into dapr:v1.10 Apr 12, 2023
@yaron2 yaron2 modified the milestones: 1.10, 1.11 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

Assignees

@owenchenxy owenchenxy

Labels
None yet
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@owenchenxy @msfussell @yaron2