Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keepalives to public api grpc server #8204

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

famarting
Copy link
Contributor

Description

Adds keepalive params to the public API grpc server, this should be now specially useful since grpc streams are used more and more (workflows and subscriptions)

NOTE: I just copied the values set in the internal server, all values are up for debate, we need find some sane defaults

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@famarting famarting requested review from a team as code owners October 16, 2024 12:27
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2 yaron2 merged commit 91ac8c2 into dapr:master Oct 16, 2024
21 of 23 checks passed
@famarting famarting deleted the public-api-configure-keepalives branch October 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants