Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pulsar-client to meet compliance #1551

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Mar 3, 2022

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Waiting for apache team to backport the changes to v0.8.0. If the backport is not done before our v1.7 release, we will go ahead with this PR which points to the commit that fixes the license issue apache/pulsar-client-go#735 v0.8.1 is released.

Description

Per reference issue, updating pulsar client to a compliant version - apache/pulsar-client-go#735

go get -u github.com/apache/pulsar-client-go
make modtidy-all

Issue reference

Please reference the issue this PR will close: #1479

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • (NA) Created/updated tests
  • (NA) Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 requested review from a team as code owners March 3, 2022 08:54
@shubham1172 shubham1172 changed the title Upgrade pulsar-client to meet compliance [Blocked] Upgrade pulsar-client to meet compliance Mar 3, 2022
@berndverst
Copy link
Member

@shubham1172 seem this is going to be in v0.8.1 -- https://github.com/apache/pulsar-client-go/tree/v0.8.1-candidate-1

@shubham1172
Copy link
Member Author

Yes @berndverst, we are waiting for them to release the v0.8.1 version. I have added more details on the linked issue.

@shubham1172 shubham1172 force-pushed the shubham1172/upgrade-pulsar-client branch from d29ec05 to d929d17 Compare March 15, 2022 09:19
@shubham1172 shubham1172 changed the title [Blocked] Upgrade pulsar-client to meet compliance Upgrade pulsar-client to meet compliance Mar 15, 2022
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndverst berndverst added this to the v1.7 milestone Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1551 (30f57d3) into master (983b7e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   35.66%   35.66%           
=======================================
  Files         160      160           
  Lines       14702    14702           
=======================================
  Hits         5244     5244           
  Misses       8880     8880           
  Partials      578      578           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9d950...30f57d3. Read the comment docs.

@berndverst berndverst merged commit d05523b into dapr:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pulsar-client-go for meeting compliance requirements
3 participants