Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dapr/components-contrib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d7ff99a
Choose a base ref
...
head repository: dapr/components-contrib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6e6601d
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 5, 2024

  1. snssqs: fix consumer starvation 

    The current implementation uses separate goroutines to process each
message retrieved by `sqsClient.ReceiveMessageWithContext`, which is
executed when `concurrencyMode` is set to `parallel`.
The `consumeSubscription` function waits for all spawned goroutines to
complete before receiving the next batch. However, this design has a
critical flaw: it starves the consumer if new messages are published
during the processing of an existing batch. These newly published
messages won't be processed until all goroutines from the original batch
have finished their work, effectively blocking the consumption of the
new messages.

This PR changes that by removing the waiting mechanism.

Signed-off-by: Gustavo Chain <me@qustavo.cc>
    @qustavo
    qustavo committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6e6601d View commit details
    Browse the repository at this point in the history
Loading