Skip to content

Conversation

@mukundansundar
Copy link
Collaborator

Description

Added a --slim flag to initialize dapr without docker.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #175

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@mukundansundar mukundansundar marked this pull request as ready for review July 6, 2020 19:21
@mukundansundar mukundansundar changed the title [WIP] Initialize dapr without docker dependency Initialize dapr without docker dependency Jul 6, 2020
@amanbha
Copy link
Contributor

amanbha commented Jul 7, 2020

  • @orizohar for the behavior of dapr init --slim

@mukundansundar mukundansundar requested a review from amanbha July 8, 2020 22:03
@orizohar
Copy link

orizohar commented Jul 8, 2020

  • @orizohar for the behavior of dapr init --slim

What part of the behavior is under discussion?

@mukundansundar mukundansundar requested a review from orizohar July 8, 2020 22:49
yaron2
yaron2 previously requested changes Jul 8, 2020
@youngbupark
Copy link
Contributor

lgtm

@amanbha
Copy link
Contributor

amanbha commented Jul 8, 2020

  • @orizohar for the behavior of dapr init --slim

What part of the behavior is under discussion?

For the overall feature behavior and doc changes.

Mukundan Sundararajan added 2 commits July 8, 2020 16:31
@mukundansundar mukundansundar requested review from orizohar and yaron2 July 9, 2020 01:03
amanbha
amanbha previously approved these changes Jul 9, 2020
vinayada1
vinayada1 previously approved these changes Jul 10, 2020
orizohar
orizohar previously approved these changes Jul 10, 2020
Copy link

@orizohar orizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit with some edits to language

@orizohar orizohar self-requested a review July 10, 2020 22:36
@mukundansundar mukundansundar dismissed yaron2’s stale review July 10, 2020 22:45

Changes addressed.

@mukundansundar mukundansundar merged commit ff2d5dd into dapr:master Jul 10, 2020
@mukundansundar mukundansundar deleted the feature/init-no-docker branch July 10, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initialize Dapr without docker

7 participants