Workflow: no longer require DB connection string #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR updates the workflow clients to use the Dapr RPCs to list Workflow instance IDs instead of connecting directly to the database. This removes the requirement that the Dapr CLI need both connectivity to the database and a connection string, greatly improving the user experience. `$ dapr workflow list` now works out-of-the-box without any additional configuration. Connection strings are still supported via the `--connection-string` flag for users using Dapr pre v1.17. Also exposes the `--force` flag on `$ dapr workflow purge` to allow purging without a worker connected. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
|
LGTM |
Contributor
|
wf e2e seem a bit red, mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates the workflow clients to use the Dapr RPCs to list Workflow instance IDs instead of connecting directly to the database. This removes the requirement that the Dapr CLI need both connectivity to the database and a connection string, greatly improving the user experience.
$ dapr workflow listnow works out-of-the-box without any additional configuration.Connection strings are still supported via the
--connection-stringflag for users using Dapr pre v1.17.Also exposes the
--forceflag on$ dapr workflow purgeto allow purging without a worker connected.