fix perfsprint linter error #1438
Conversation
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
cmd/dashboard.go
Outdated
| @@ -180,7 +181,7 @@ dapr dashboard -k -p 0 | |||
| }() | |||
|
|
|||
| // url for dashboard after port forwarding. | |||
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, fmt.Sprint(portForward.LocalPort))) //nolint: perfsprint | |||
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort))) | |||
There was a problem hiding this comment.
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort))) | |
| webURL := "http://" + net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort)) |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@KentHsu could you please apply the suggested change? It'll fix the lint error. TY! |
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
|
Hi @antontroshin , it's updated based on your suggestion. Please let me know if there's other issues blocking this PR. Thank you. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
Removed
//nolint: perfsprintdirective and fixed all perfsprint linter errorIssue reference
Please reference the issue this PR will close: #1374
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: