Skip to content

Remove volumes for non-execution packages #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablomendezroyo merged 1 commit into from
Jan 27, 2026
Merged

Remove volumes for non-execution packages #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions internal/adapters/apis/dappmanager/dappmanager_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,12 @@ func (d *DappManagerAdapter) RemoveNonCorePackages(ctx context.Context) (skipped
skipped = append(skipped, pkg.DnpName)
continue
}
deleteVolumes := true

var deleteVolumes bool
if isExecutionPackage(pkg.DnpName) {
deleteVolumes = false
} else {
deleteVolumes = true
}
err := d.removePackage(ctx, pkg.DnpName, &deleteVolumes)
if err != nil {
errors = append(errors, fmt.Errorf("failed to remove package %s: %w", pkg.DnpName, err))
Expand All @@ -256,3 +260,15 @@ func (d *DappManagerAdapter) RemoveNonCorePackages(ctx context.Context) (skipped
}
return skipped, errors
}

// isExecutionPackage returns true if the dnpName is an execution client
func isExecutionPackage(dnpName string) bool {
execs := []string{"geth", "besu", "erigon", "reth", "nethermind"}
lower := strings.ToLower(dnpName)
for _, exec := range execs {
if strings.Contains(lower, exec) {
return true
}
}
return false
}