Skip to content

Conversation

@pablomendezroyo
Copy link
Contributor

This pull request refactors the test runner's composite adapter system, consolidating and renaming it as the TestManagerAdapter. It simplifies adapter initialization, removes unused adapters, and introduces a new snapshot version adapter. Additionally, it improves version tracking and error handling in environment setup and reporting.

Major refactoring and consolidation:

  • Replaces the old CompositeAdapter with a new TestManagerAdapter, moving and renaming related files and types from internal/adapters/composite to internal/adapters/composite/testmanager. The new adapter now initializes all required sub-adapters internally, reducing complexity in main.go and centralizing test environment management. [1] [2] [3] [4] [5] [6]
  • Removes unused adapters (snapshots, blocknumber, etc.) from the main runner and composite adapter construction, streamlining dependencies and setup. [1] [2] [3] [4] [5] [6]

New snapshot version support:

  • Adds a new snapshotversion.Adapter in internal/adapters/shared/snapshotversion, which reads and parses a snapshot version file for improved version tracking. This adapter is now included in the environment setup process. [1] [2] [3]

Improved version tracking and error handling:

  • Refactors client version retrieval in the environment setup to use a retry mechanism, improving reliability when clients are slow to start after installation. [1] [2]
  • Updates the test report markdown output to always include both execution and consensus client version tables, regardless of test type, for clearer reporting. [1] [2] [3]

Other improvements:

  • Ensures PR commenting errors are logged but do not fail the test run, improving robustness in CI environments.

Overall, these changes modernize and simplify the test runner's architecture, improve reliability, and enhance reporting for client and snapshot versions.

@pablomendezroyo pablomendezroyo merged commit 77b2eb7 into main Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants