Implement resilient IPFS fetcher #2336
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketen
reviewed
Jan 8, 2026
Contributor
There was a problem hiding this comment.
this file should be deleted right? content is the same as in new ipfsGatewayUrlsGet/ts.
Contributor
There was a problem hiding this comment.
same, should be deleted if ipfsGatewayUrlsSet.ts is enough
Comment on lines
+9
to
+41
| export async function ipfsGatewayUrlsSet({ ipfsGatewayUrls }: { ipfsGatewayUrls: string[] }): Promise<void> { | ||
| if (!ipfsGatewayUrls || ipfsGatewayUrls.length === 0) { | ||
| throw Error(`At least one gateway URL must be provided`); | ||
| } | ||
|
|
||
| await changeIpfsGatewayUrls(ipfsGatewayUrls); | ||
|
|
||
| // Emit event to trigger notifier healthcheck notification | ||
| eventBus.ipfsRepositoryChanged.emit(); | ||
| } | ||
|
|
||
| /** | ||
| * Changes IPFS gateway URLs used for package fetching | ||
| * @param nextGatewayUrls Gateway endpoints to be used | ||
| */ | ||
| async function changeIpfsGatewayUrls(nextGatewayUrls: string[]): Promise<void> { | ||
| try { | ||
| // Return if gateway URLs are equal | ||
| const currentGatewayUrls = db.ipfsGatewayUrls.get(); | ||
| if (JSON.stringify(currentGatewayUrls) === JSON.stringify(nextGatewayUrls)) { | ||
| return; | ||
| } | ||
|
|
||
| // Set new values in db | ||
| const gatewayUrls = nextGatewayUrls.length > 0 ? nextGatewayUrls : params.IPFS_REMOTE_URLS; | ||
| db.ipfsGatewayUrls.set(gatewayUrls); | ||
|
|
||
| // Change IPFS gateway URLs in the installer | ||
| dappnodeInstaller.changeIpfsGatewayUrls(db.ipfsGatewayUrls.get()); | ||
| } catch (e) { | ||
| throw Error(`Error changing IPFS gateway URLs, ${e}`); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
seems like changeIpfsGatewayUrls() and ipfsGatewayUrlsSet() are overlapping, they do the same or have too similar names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request introduces a new mechanism for fetching content from IPFS using multiple gateway URLs, enhancing resilience and reliability in content retrieval.
Approach
The solution involves modifying the IPFS repository structure to support an array of gateway URLs, implementing functions to set and get these URLs, and updating the metrics to reflect the number of configured gateways.
Test instructions
ipfsGatewayUrlsSetfunction.ipfsGatewayUrlsGetfunction.