Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git tag generation #445

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix git tag generation #445

merged 1 commit into from
Jul 25, 2024

Conversation

dappnodedev
Copy link
Contributor

@dappnodedev dappnodedev commented Jul 25, 2024

SDK publish action in mono-variant package repos would fail with this error:

[07:14:41] Release on github [started]
[07:14:41] Handle tags [started]
[07:14:41] Handle tags [failed]
[07:14:41] → Missing required release details for dappmanager.dnp.dappnode.eth
[07:14:41] Release on github [failed]
[07:14:41] → Missing required release details for dappmanager.dnp.dappnode.eth
 ✖ Missing required release details for dappmanager.dnp.dappnode.eth

Error: Missing required release details for dappmanager.dnp.dappnode.eth
    at buildReleaseDetailsMap (file:///home/runner/.npm/_npx/7366de4368e80aba/node_modules/@dappnode/dappnodesdk/src/tasks/createGithubRelease/buildReleaseDetailsMap.ts:14:13)
    at Task.task (file:///home/runner/.npm/_npx/7366de4368e80aba/node_modules/@dappnode/dappnodesdk/src/tasks/createGithubRelease/subtasks/getHandleTagsTask.ts:30:33)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

This PR aims to fix this bug by handling the case where variant is null. This happens when there are no variants for a package repo

@dappnodedev dappnodedev requested a review from a team as a code owner July 25, 2024 09:24
@dappnodedev dappnodedev merged commit 2fe63b0 into master Jul 25, 2024
8 of 10 checks passed
@dappnodedev dappnodedev deleted the bugfix/release-details-map branch July 25, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants