Add content hashes to release #441
Conversation
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 010521f This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
|
The best approach would be merging #443 and then rebasing before merging this PR |
There was a problem hiding this comment.
This file has no changes apart from identation
| @@ -195,9 +198,9 @@ export class Github { | |||
| body?: string; | |||
| prerelease?: boolean; | |||
| } | |||
| ): Promise<void> { | |||
| ): Promise<number> { | |||
There was a problem hiding this comment.
Only change here: This funcion now returns releaseID
| "content-type": contentType, | ||
| "content-length": fs.statSync(filepath).size | ||
| }, | ||
| name: `${fileNamePrefix || ""}${path.basename(filepath)}` |
There was a problem hiding this comment.
Adds prefix for multivariant packages. For example:
If variant is holesky for Obol package, content-hash file name will be holesky-obol_content-hash
| } | ||
| }; | ||
| } | ||
|
|
||
| async function handleReleaseVariantFiles({ | ||
| function prepareGithubReleaseFiles({ |
There was a problem hiding this comment.
Creates content-hash file, compacts manifest and deletes build properties from compose
dappnodedev
force-pushed
the
bugfix/add-content-hashes-to-release
branch
from
d4a5955
to
eaa4d12
Compare
Release needs to include content hashes, as it is used to enable packages download in case there is no Ethereum node available: dappnode/DNP_CORE#184
With this code, the releases for standard packages will look like:
And the releases for multi-variant packages will look like:
