Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Create Github releases #434

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Bugfix: Create Github releases #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06eccf4
Bump octokit version
dappnodedev Jun 17, 2024
3504c02
Fix Github release creation
dappnodedev Jun 17, 2024
156b1cb
Update all github requests
dappnodedev Jun 17, 2024
7869211
Do not upload release assets
dappnodedev Jun 17, 2024
ff11428
Use octokit.rest
dappnodedev Jun 18, 2024
5129d33
Improve Github error handling
dappnodedev Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
pablomendezroyo marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@dappnode/schemas": "^0.1.20",
"@dappnode/toolkit": "^0.1.21",
"@dappnode/types": "^0.1.39",
"@octokit/rest": "^18.0.12",
"@octokit/rest": "^20.1.1",
dappnodedev marked this conversation as resolved.
Show resolved Hide resolved
"async-retry": "^1.2.3",
"chalk": "^2.4.2",
"cli-progress": "^3.8.2",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/githubActions/build/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export async function buildAndComment({

console.log(`Build bot comment: \n\n${body}`);

const prs = await github.getOpenPrsFromBranch({ branch });
const prs = await github.getOpenPrsFromBranch(branch);
console.log(`
Repo: ${github.repoSlug}
Branch ${branch}
Expand Down
6 changes: 3 additions & 3 deletions src/commands/githubActions/bumpUpstream/github/closeOldPrs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export async function closeOldPrs(
* Get the open PR for a given branch.
*/
async function getNewPr(thisRepo: Github, newBranch: string) {
const [newPr] = await thisRepo.getOpenPrsFromBranch({ branch: newBranch });
const [newPr] = await thisRepo.getOpenPrsFromBranch(newBranch);
if (!newPr) throw Error(`No PR found for branch ${newBranch}`);
return newPr;
}
Expand All @@ -45,7 +45,7 @@ async function closePrsAndDeleteBranch(
newPrUrl: string
) {
try {
const prs = await thisRepo.getOpenPrsFromBranch({ branch: oldBranch });
const prs = await thisRepo.getOpenPrsFromBranch(oldBranch);
await Promise.all(prs.map(pr => closePr(thisRepo, pr, newPrUrl)));
await deleteBranch(oldBranch);
} catch (error) {
Expand All @@ -62,7 +62,7 @@ async function closePr(
newPrUrl: string
) {
try {
await thisRepo.commentPullRequest({
await thisRepo.createCommentInPr({
number: pr.number,
body: `Newer version available, closing for ${newPrUrl}`
});
Expand Down
2 changes: 1 addition & 1 deletion src/commands/githubActions/bumpUpstream/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ async function attemptToOpenPR({

await repo.openPR({
from: branchName,
to: repoData.data.default_branch,
to: repoData.default_branch,
title: commitMsg,
body: getBumpPrBody(upstreamSettings)
});
Expand Down
Loading
Loading