Skip to content

Conversation

bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Mar 17, 2022

examples/aio_pika_*.py: Implement shutdown RPC to support restarting the server

Add RPC method to terminate the server, useful for restarting it with updated code:

Especially useful during development of new code, for example using https://github.com/Almenon/AREPL-vscode and a loop
for the client as well: while true;do python examples/aio_pika_client.py;sleep 1;done

@bernhardkaindl bernhardkaindl changed the base branch from master to dev March 30, 2022 13:34
@bernhardkaindl bernhardkaindl force-pushed the v1.4.1/examples/pika-shutdown branch 2 times, most recently from 2e993c4 to f73f9d0 Compare March 30, 2022 20:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #61 (bc84844) into dev (68d17db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #61   +/-   ##
=======================================
  Coverage   78.71%   78.71%           
=======================================
  Files          40       40           
  Lines        2584     2584           
=======================================
  Hits         2034     2034           
  Misses        550      550           
Flag Coverage Δ
unittests 78.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d17db...bc84844. Read the comment docs.

@bernhardkaindl bernhardkaindl force-pushed the v1.4.1/examples/pika-shutdown branch from f73f9d0 to f25e072 Compare March 31, 2022 15:46
@bernhardkaindl bernhardkaindl changed the title examples/aio_pika_*.py: Implement shutdown RPC for server restart examples/aio_pika_*.py: Implement shutdown RPC to support restarting the server Mar 31, 2022
@bernhardkaindl bernhardkaindl requested a review from dapper91 March 31, 2022 15:59
@bernhardkaindl bernhardkaindl requested a review from dapper91 March 31, 2022 17:35
Add an RPC method to terminate the server, useful for restarting it
with updated code. Especially useful during development of new code,
for example using https://github.com/Almenon/AREPL-vscode and a loop
for the client: while true;do examples/aio_pika_client.py;sleep 1;done
@bernhardkaindl bernhardkaindl force-pushed the v1.4.1/examples/pika-shutdown branch from f25e072 to bc84844 Compare May 27, 2022 06:40
@bernhardkaindl bernhardkaindl changed the title examples/aio_pika_*.py: Implement shutdown RPC to support restarting the server examples/aio_pika_*.py: example RPC to schedule a shutdown (e.g. for restart) May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants