Skip to content

Comments

Various fixes / minor changes#19

Merged
daot merged 8 commits intodaot:masterfrom
01luna:master
Dec 2, 2025
Merged

Various fixes / minor changes#19
daot merged 8 commits intodaot:masterfrom
01luna:master

Conversation

@01luna
Copy link
Contributor

@01luna 01luna commented Oct 18, 2025

fixes #17

I don't know why bandcamp does this. Alll the data is still in the original request but as an array of json objects in an html attribute,

Applies to most (not all) artists with >16 releases. Started some time in 2024.

@01luna 01luna marked this pull request as draft October 18, 2025 18:19
@01luna 01luna marked this pull request as ready for review October 18, 2025 18:20
@01luna
Copy link
Contributor Author

01luna commented Oct 19, 2025

also fixed a crash that would occur when the redownload link on the collection page returned 404

-moved relevant code
-changed --overwrite from a bool flag to an enum
-added the --skip flag to unconditionally skip downloads at the start
@01luna
Copy link
Contributor Author

01luna commented Oct 19, 2025

-changed the --overwrite flag from a bool to an enum of ("always","never","ask")
-fixed the overwrite checking not being applied when downloading from user's collection
-added --skip=N flag to skip the first N downloads

@01luna 01luna changed the title Get links for javascript-rendered entries on artist pages Various fixes / minor changes Oct 19, 2025
@01luna 01luna closed this Nov 16, 2025
@01luna
Copy link
Contributor Author

01luna commented Nov 16, 2025

Closed for now; May create new PR with individual changes.

@daot daot reopened this Dec 2, 2025
@daot daot merged commit 56781d1 into daot:master Dec 2, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bcdl doesn't parse the whole albums list for a given bandcamp link

2 participants