DAOToken is none upgradable proxy #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkent600
suggested changes
Oct 17, 2020
contracts/utils/DAOFactory.sol
Outdated
| * This parameter is optional, if no data is given the initialization call to proxied contract will be skipped. | ||
| * @return Address of the new proxy. | ||
| */ | ||
| function createNoneUpgradableInstance(uint64[3] memory _packageVersion, |
There was a problem hiding this comment.
misspelled. should be everywhere createNonUpgradableInstance
contracts/utils/DAOFactory.sol
Outdated
| @@ -164,6 +165,32 @@ contract DAOFactory is Initializable { | |||
| delete locks[address(_avatar)]; | |||
| } | |||
|
|
|||
| /** | |||
| * @dev createNoneUpgradableInstance creates a new proxy for the given contract and forwards a function call to it. | |||
There was a problem hiding this comment.
This description of the function doesn't seem to match the function name.
added 2 commits
October 18, 2020 09:22
ben-kaufman
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.