WIP - do not merge #3683
Open
WIP - do not merge #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daosbuild1
requested changes
Oct 16, 2020
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-3683/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
| @@ -3928,7 +3955,7 @@ dc_obj_update(tse_task_t *task, struct dtx_epoch *epoch, uint32_t map_ver, | |||
| D_DEBUG(DB_IO, "update "DF_OID" dkey_hash "DF_U64"\n", | |||
| DP_OID(obj->cob_md.omd_id), dkey_hash); | |||
|
|
|||
| rc = obj_rw_bulk_prep(obj, args->iods, args->sgls, args->nr, true, | |||
| rc = obj_rw_bulk_prep(obj, args->iods, obj_auxi->agg_sgls, args->nr, true, | |||
There was a problem hiding this comment.
(style) line over 80 characters
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-3683/1/execution/node/60/log |
|
Test stage Functional on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-3683/1/execution/node/866/log |
mchaarawi
force-pushed
the
mschaara/aggregate_sgl
branch
from
e29178d
to
028aa43
Compare
mchaarawi
force-pushed
the
mschaara/aggregate_sgl
branch
from
028aa43
to
ed62989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggregate sgl when user buffer is very fragmented.
Signed-off-by: Mohamad Chaarawi mohamad.chaarawi@intel.com