Skip to content

DAOS-18001 control: Fix dmg JSON error output - #19225

Merged
daltonbohning merged 1 commit into
masterfrom
kjacque/dmg-check-query-correct-state
Oct 12, 2026
Merged

DAOS-18001 control: Fix dmg JSON error output#19225
daltonbohning merged 1 commit into
masterfrom
kjacque/dmg-check-query-correct-state

Conversation

@kjacque

@kjacque kjacque commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Several checker commands were displaying JSON output with no error before checking if an error was returned.

Features: recovery

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kjacque
DAOS-18001 control: Fix dmg JSON error output
832827d 
Several checker commands were displaying JSON output with no error
before checking if an error was returned.

Features: recovery

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@kjacque kjacque self-assigned this Oct 8, 2026
@kjacque
kjacque requested review from a team as code owners October 8, 2026 23:58
@github-actions

github-actions Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Ticket title is '1-./recovery/ms_membership.py:MSMembershipTest.test_checker_on_admin_excluded - dmg check query does not return an error when expected'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18001

@kjacque
kjacque requested review from knard38, mjmac and tanabarr October 8, 2026 23:58
@kjacque kjacque added control-plane work on the management infrastructure of the DAOS Control Plane CR Catastrophic Recovery Feature labels Oct 8, 2026
@kjacque
kjacque requested a review from daltonbohning October 9, 2026 16:03
@daosbuild3

daosbuild3 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19225/1/execution/node/1995/log

@kjacque

kjacque commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

CI failures were two instances of this known issue: https://daosio.atlassian.net/browse/DAOS-19705

It looks like the CI actually finished, even though the verbs provider stage is showing unfinished in GHA. Requesting forced-landing.

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 12, 2026
@kjacque
kjacque requested a review from a team October 12, 2026 16:48
@daltonbohning daltonbohning added the release-3.0.0 Targeted for release 3.0.0 label Oct 12, 2026
@daltonbohning
daltonbohning merged commit d29a794 into master Oct 12, 2026
43 of 45 checks passed
@daltonbohning
daltonbohning deleted the kjacque/dmg-check-query-correct-state branch October 12, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjmac mjmac mjmac approved these changes
@daltonbohning daltonbohning daltonbohning approved these changes
@knard38 knard38 knard38 approved these changes
@tanabarr tanabarr Awaiting requested review from tanabarr

Assignees

@kjacque kjacque

Labels

control-plane work on the management infrastructure of the DAOS Control Plane CR Catastrophic Recovery Feature forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. release-3.0.0 Targeted for release 3.0.0

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kjacque @daosbuild3 @mjmac @daltonbohning @knard38