Skip to content

Conversation

@phender
Copy link
Contributor

@phender phender commented Mar 15, 2024

Bump version to 2.5.101

Skip-func-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Bump version to 2.5.101

Skip-func-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from a team as a code owner March 15, 2024 18:13
@github-actions
Copy link

Ticket title is 'Create 2.6 TB1'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15438

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14000/1/testReport/

@phender
Copy link
Contributor Author

phender commented Mar 15, 2024

@phender
Copy link
Contributor Author

phender commented Mar 18, 2024

@phender phender requested a review from a team March 18, 2024 13:16
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Mar 18, 2024
@phender
Copy link
Contributor Author

phender commented Mar 18, 2024

Force landing requested as functional tests were skipped. These tests are performed with the test build RPMs in separate test branches after the PR is landed.

@daltonbohning daltonbohning merged commit 313fa74 into master Mar 18, 2024
@daltonbohning daltonbohning deleted the pahender/DAOS-15438 branch March 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

5 participants