Skip to content

DAOS-15347 build: Tag 2.4.2 rc3 #13928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daltonbohning merged 1 commit into from
Mar 4, 2024
Merged

DAOS-15347 build: Tag 2.4.2 rc3 #13928

daltonbohning merged 1 commit into from
Mar 4, 2024

Conversation

@phender
Copy link
Contributor

@phender phender commented Mar 4, 2024

Tag third release candidate for 2.4.2.

Skip-func-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-15347 build: Tag 2.4.2 rc3
d603a77 
Tag third release candidate for 2.4.2.

Skip-func-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from a team as a code owner March 4, 2024 20:17
@github-actions
Copy link

github-actions bot commented Mar 4, 2024

Bug-tracker data:
Ticket title is 'Build 2.4.2 RC3'
Status is 'In Progress'
Labels: '2.4.2rc3'
https://daosio.atlassian.net/browse/DAOS-15347

daosbuild1
daosbuild1 reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@phender phender requested a review from a team March 4, 2024 21:33
@daltonbohning daltonbohning merged commit bf9ac88 into release/2.4 Mar 4, 2024
@daltonbohning daltonbohning deleted the pahender/DAOS-15347 branch March 4, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mchaarawi mchaarawi mchaarawi approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@ryon-jensen ryon-jensen ryon-jensen approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@phender @mchaarawi @daltonbohning @ryon-jensen @daosbuild1