Skip to content

DAOS-14365 build: Tag 2.4.0 rc2 #13059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daltonbohning merged 1 commit into from
Sep 15, 2023
Merged

DAOS-14365 build: Tag 2.4.0 rc2 #13059

daltonbohning merged 1 commit into from
Sep 15, 2023

Conversation

@phender
Copy link
Contributor

@phender phender commented Sep 15, 2023

Tag second release candidate for 2.4.0.

Skip-func-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-14365 build: Tag 2.4.0 rc2
aee2319 
Tag second release candidate for 2.4.0.

Skip-func-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from a team as a code owner September 15, 2023 14:13
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Bug-tracker data:
Ticket title is 'Build 2.4.0 RC2'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-14365

daosbuild1
daosbuild1 reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@phender phender requested a review from a team September 15, 2023 15:48
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 15, 2023
@daltonbohning daltonbohning merged commit 915a753 into release/2.4 Sep 15, 2023
@daltonbohning daltonbohning deleted the pahender/DAOS-14365 branch September 15, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@tanabarr tanabarr tanabarr approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@sylviachanoiyee sylviachanoiyee sylviachanoiyee approved these changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@phender @tanabarr @daltonbohning @sylviachanoiyee @daosbuild1