Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: REPL should not crash on runtime errors #47

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Conversation

danvk
Copy link
Owner

@danvk danvk commented Feb 4, 2024

Overview

Fixes #45

The interesting part is testing.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7de2479) 97.73% compared to head (1517eaf) 97.99%.

Files Patch % Lines
src/main.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   97.73%   97.99%   +0.25%     
==========================================
  Files          17       17              
  Lines        2032     2040       +8     
  Branches      339      345       +6     
==========================================
+ Hits         1986     1999      +13     
+ Misses         45       40       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk merged commit 43dd522 into main Feb 4, 2024
12 checks passed
@danvk danvk deleted the runtime-repl-crash branch February 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Runtime errors crash the REPL
1 participant