Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Added Symfony 3 support #8

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Conversation

chirimoya
Copy link
Collaborator

@chirimoya chirimoya commented Dec 5, 2016

@dantleech
Copy link
Owner

Hmm travis tests failing with memory issues, will have to have a look later.

@chirimoya
Copy link
Collaborator Author

Maybe the minimum-stability dev causes this error. Looks like the object graph get too big.

@chirimoya
Copy link
Collaborator Author

sulu/sulu#2106

@QuingKhaos QuingKhaos mentioned this pull request Dec 5, 2016
61 tasks
@dantleech
Copy link
Owner

Lets switch it to stable and see what happens, don't think there is any good reason why it should be dev

@chirimoya
Copy link
Collaborator Author

@dantleech ... now only the symfony 2.3 tests are failing, but it looks like it was already broken ... https://travis-ci.org/dantleech/phpcr-migrations-bundle/builds/127595329

@dantleech
Copy link
Owner

Yeah, would like to drop that, maybe I will tag a major release.

@dantleech dantleech merged commit 2ea5af8 into dantleech:master Dec 5, 2016
@dantleech
Copy link
Owner

btw, how is this bundle working out for you guys now? stable? might as well release 1.0 ?

@chirimoya chirimoya deleted the symfony-3-support branch December 5, 2016 15:04
@chirimoya
Copy link
Collaborator Author

chirimoya commented Dec 5, 2016

yes, we use it for our release upgrade migrations. works fine so far. but maybe @danrot or @wachterjohannes do have more on this topic.

@wachterjohannes
Copy link
Collaborator

@chirimoya @dantleech it works quite fine for sulu - in my opinion its "improvable" in the future but could be released now

@danrot
Copy link

danrot commented Dec 6, 2016

For me it's working fine. As I already mentioned in a tweet the interface is pretty straight forward, and I wouldn't know about any huge improvement which could be done right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants