Add PHP 8.2 and Monolog 3 to Test Matrix, drop Support for PHP 7.2 and 7.3

[alexander-schranz]

Currently PHP 8.2 and Monolog 3 is not tested.

Requires:

• phpcr implementation package now required?!? Add PHP 8.2 and Monolog 3 to Test Matrix, drop Support for PHP 7.2 and 7.3 #20 (comment)
• Call AnnotationRegistry registerLoader only when available symfony-cmf/Testing#213
• symfony-cmf/testing 4.4.2 tag

[alexander-schranz]

Not sure why this is now required:

https://github.com/dantleech/phpcr-migrations-bundle/actions/runs/4436191849/jobs/7784305593

Maybe @dbu has a hint

[alexander-schranz]

Also ^2.0@dev currently not possible because of:

#20 (comment)

[dbu]

looks like i need to upgrade the phpcr-bundle for jackalope 2 - i did not do that yet.

for the need to require jackalope: i think this has been necessary before as well - phpcr-odm does not require a specific phpcr implementation. is the ci build of this bundle not requiring jackalope dynamically?

[alexander-schranz]

for the need to require jackalope: i think this has been necessary before as well - phpcr-odm does not require a specific phpcr implementation. is the ci build of this bundle not requiring jackalope dynamically

It seems not: https://github.com/dantleech/phpcr-migrations-bundle/blob/master/.github/workflows/ci.yaml

There is no log of the last run but atleast last year it seems to have run without problems without require a phpcr implementation 🤔 :

https://github.com/dantleech/phpcr-migrations-bundle/commits/master

[alexander-schranz]

I thought it is not worth to invest in supporting PHP 7.2 and 7.3 and remove it from the matrix and composer.json:

@dantleech what do you think about dropping PHP 7.2 / 7.3 support. For Sulu 1.6 we require 7.4 still if there would appear any bugs but only until we hopelly release this year Sulu 3.0.

[dantleech]

what do you think about dropping PHP 7.2 / 7.3 support.

drop away!

[alexander-schranz]

@dbu I think we could tag the merged symfony-cmf/Testing#213 so I can remove here dev-master?

[dbu]

sorry, this went under. i created the tag now: https://github.com/symfony-cmf/Testing/releases/tag/4.4.2

[alexander-schranz]

composer.json updated

[dbu]

i would only install one of dbal or jackrabbit. and you don't need to require jackalope/jackalope separately, it is required by the actual implementations.

as to why this suddenly comes up: maybe old versions of symfony-cmf/testing did require jackalope but the newest one no longer does? you'd need to compare composer.json of symfony-cmf/testing if you want to be sure.

but imho requiring something explicitly here is a good idea anyways. you might also need to do a bit of setup in the ci steps to be able to use the implementation if there are functional tests in this repository.

[alexander-schranz]

i required the jackalope-doctrine-dbal for now. Maybe @dantleech can tell us if something specific is required, from my side ready for review :)

[dbu]

looks sane to me. but i am no maintainer of this bundle and have not used it...

i'd suggest to squash the commits as there was some back and forth in the commits ;-)