fix: convert AvailableVersion to string for proper display#58
Merged
Conversation
The Version object from Find-Module was being stored directly, causing it to display as a hashtable after JSON serialization/deserialization. Adding .ToString() ensures consistent string formatting matching CurrentVersion behavior. Fixes #57
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
.ToString()to$Available.Versionin both PS7+ parallel and legacy code pathsProblem
When displaying PowerShell module updates, the
AvailableVersioncolumn showed:instead of
15.2.0.Root Cause
The
Versionobject fromFind-Modulewas stored directly. After JSON serialization/deserialization, it lost its type information and displayed as a hashtable.Fix
Convert to string before storing (matching
CurrentVersionbehavior):Fixes #57
PR Type
Bug fix
Description
Convert AvailableVersion to string
Add .ToString() in parallel code branch
Add .ToString() in legacy code branch
File Walkthrough
Get-Updates.ps1
Convert AvailableVersion to stringfunctions/Get-Updates.ps1
.ToString()for AvailableVersion in parallel path.ToString()for AvailableVersion in legacy path