Skip to content

feat: implement data source and data view management features #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danships merged 2 commits into from
Oct 30, 2025
Merged

feat: implement data source and data view management features #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2563497
feat: implement data source and data view management features
danships Oct 30, 2025
50c14c0
chore: review notes
danships Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ jobs:
~/.npm
${{ github.workspace }}/.next/cache
# Generate a new cache whenever packages or source files change.
key: ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }}
key: ${{ runner.os }}-nextjs-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }}
# If source files changed but packages didn't, rebuild from a prior cache.
restore-keys: |
${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json') }}-
${{ runner.os }}-nextjs-${{ hashFiles('**/pnpm-lock.yaml') }}-

- name: Run build
run: pnpm build
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
pnpm lint
pnpm lint-staged
19 changes: 19 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"prettier.enable": true,
"eslint.enable": true,
"eslint.validate": ["svelte", "typescript", "javascript"],
"[css]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[scss]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[html]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[json]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[jsonc]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[markdown]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[javascript]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[typescript]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
"[typescriptreact]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }
}
6 changes: 6 additions & 0 deletions lint-staged.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/* eslint-disable import/no-anonymous-default-export */
export default {
'*': 'prettier --write --ignore-unknown',
'*.(js|cjs|mjs|jsx|ts|tsx|svelte)': 'eslint --max-warnings 0',
'*.(ts|tsx)': () => 'tsc -p tsconfig.json --noEmit',
Comment on lines +4 to +5
Copy link

@coderabbitai coderabbitai bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the glob pattern syntax.

The glob patterns use incorrect syntax with parentheses () instead of curly braces {}. Lint-staged uses micromatch for glob matching, which requires curly braces for alternation patterns.

Apply this diff to fix the glob patterns:

-  '*.(js|cjs|mjs|jsx|ts|tsx|svelte)': 'eslint --max-warnings 0',
-  '*.(ts|tsx)': () => 'tsc -p tsconfig.json --noEmit',
+  '*.{js,cjs,mjs,jsx,ts,tsx,svelte}': 'eslint --max-warnings 0',
+  '*.{ts,tsx}': () => 'tsc -p tsconfig.json --noEmit',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'*.(js|cjs|mjs|jsx|ts|tsx|svelte)': 'eslint --max-warnings 0',
'*.(ts|tsx)': () => 'tsc -p tsconfig.json --noEmit',
'*.{js,cjs,mjs,jsx,ts,tsx,svelte}': 'eslint --max-warnings 0',
'*.{ts,tsx}': () => 'tsc -p tsconfig.json --noEmit',
🤖 Prompt for AI Agents 
In lint-staged.config.js around lines 4 to 5, the glob patterns use parentheses
for alternation which is invalid for micromatch; replace the patterns using
parentheses with curly-brace alternation. Change
'*.(js|cjs|mjs|jsx|ts|tsx|svelte)' to '*.{js,cjs,mjs,jsx,ts,tsx,svelte}' and
'*.(ts|tsx)' to '*.{ts,tsx}', keeping the same command strings so eslint and tsc
run against the corrected globs.

};
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"@mantine/core": "^8.3.4",
"@mantine/form": "^8.3.5",
"@mantine/hooks": "^8.3.4",
"@nanostores/query": "^0.3.4",
"@nanostores/react": "^1.0.0",
"@tabler/icons-react": "^3.35.0",
"axios": "^1.12.2",
Expand All @@ -35,6 +34,7 @@
"react": "19.1.0",
"react-dom": "19.1.0",
"supersave": "^0.20.0",
"swr": "^2.3.6",
"winston": "^3.18.3",
"zod": "^4.1.12"
},
Expand All @@ -55,6 +55,7 @@
"eslint-plugin-unicorn": "^61.0.2",
"express": "^5.1.0",
"husky": "^9.1.7",
"lint-staged": "^16.2.6",
"prettier": "^3.6.2",
"rimraf": "^6.0.1",
"typescript": "^5.9.3"
Expand Down
Loading