feat: update OIDC configuration to be optional and enhance auth#15
Merged
feat: update OIDC configuration to be optional and enhance auth#15
Conversation
…tion logic - Made OIDC environment variables optional in the configuration, allowing for fallback to credentials authentication if not set. - Added a function to check for OIDC configuration presence and adjusted the authentication initialization logic accordingly.
WalkthroughIntroduces server startup automation with environment variable resolution and persistence, alongside conditional authentication support for OIDC and email/password modes. The startup script resolves database connection details and auth secrets (with file-based caching), while the auth config adapts authentication strategy based on OIDC environment variables. Changes
Sequence Diagram(s)sequenceDiagram
participant StartScript as Startup Script
participant EnvResolver as Environment Resolver
participant AuthConfig as Auth Config
participant BetterAuth as Better Auth
participant Database as Database
participant Server as Next.js Server
StartScript->>StartScript: Resolve THOTH_HOME_DIR<br/>(or default ~/.thoth)
StartScript->>StartScript: Resolve DB env var<br/>(or default MySQL URL)
StartScript->>StartScript: Resolve BETTER_AUTH_SECRET<br/>(from env or home dir file)
StartScript->>EnvResolver: Inject resolved vars
EnvResolver->>AuthConfig: Pass environment variables
AuthConfig->>AuthConfig: Check OIDC completeness<br/>(hasOidcConfig)
alt OIDC Fully Configured
AuthConfig->>BetterAuth: Initialize with OIDC<br/>via genericOAuth
else OIDC Not Configured
AuthConfig->>BetterAuth: Initialize with<br/>email/password auth
end
BetterAuth->>Database: Setup auth database<br/>with hooks
AuthConfig->>Server: Merged config
StartScript->>Server: Spawn with env vars
Server->>Server: Start listening
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: update OIDC configuration to be optional and enhance authentication logic
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.