Add pytest-xdist depencency to pydevtool.txt and tests_require #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add pytest-xdist to the lists of dependencies to allow developers to run the tests out of the box, without having to manually install pytest-xdist.
When I first checked out the repo and tried to run the tests, I was met by an error:
unrecognized arguments: -n4. I'm guessing that this argument was added to pytest.ini to enable multithreaded test execution through pytest-xdist? If so, I added it as a dependency in pydevtool.txt so that developers should be able to run the tests directly after following the development setup instructions.I also added it to the
tests_requirelist in setup.py because it seemed like the right thing to do. I'm not really a python dev though, so this is mostly a guess.