Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small fixes #69

Merged
merged 1 commit into from
Jan 7, 2019
Merged

More small fixes #69

merged 1 commit into from
Jan 7, 2019

Conversation

hhadian
Copy link

@hhadian hhadian commented Jan 7, 2019

This fixes the dim mismatch problem. Please take a look at the changes because I'm not sure this is the right fix.

Currently it runs up to stage 15 of run_tdnn_1a.sh but it can't go further because of this error (related to xconfigs of the top network):

ERROR:root:***Exception caught while parsing the following xconfig line:
***   tdnnf-layer name=tdnnf1 l2-regularize=0.03 dropout-proportion=0.0 bypass-scale=0.66 dim=768 bottleneck-dim=96 time-stride=1
...
File "steps/libs/nnet3/xconfig/utils.py", line 518, in replace_bracket_expressions_in_descriptor
    "invalid or out of range offset.".format(descriptor_string, fields[i]))
RuntimeError: Error tokenizing string '[-1]': expression [-1] has an invalid or out of range offset.

It seems like it's expecting an input layer for the first layer (tdnnf1).

@danpovey danpovey merged commit f057108 into danpovey:svd_draft Jan 7, 2019
@danpovey
Copy link
Owner

danpovey commented Jan 7, 2019

Thanks. I fixed the xconfig, I think.

@hhadian
Copy link
Author

hhadian commented Jan 7, 2019

Some notes:

  1. What is the 0 in this line: nnet3-init --srand=$srand $dir/configs/default.config 0 -? (L236)
  2. Also I can't find this file: steps/chaina/get_model_context.sh
  3. It seems that the bottom network (bottom.raw) and transform network (default.ada) are never used in the script after they are created.

@danpovey
Copy link
Owner

danpovey commented Jan 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants