Performance increase #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade `phpseclib/phpseclib` from `2.0.4` to `dev-master`
|
I merged this because the metrics looked freaking good, but now I noticed that this breaks compatibility for php < 7. |
This was referenced Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpseclib/phpseclibfrom2.0.4todev-masterI observed a good decrease of execution time of application with this change.
using 2.0.4:
396 different functions called in 121885 milliseconds (1 runs, 396 shown)
using dev-master:
357 different functions called in 55321 milliseconds (1 runs, 357 shown)