Add enetities to Message class #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make entity property as public - Add support for objects in getHTML method!
|
Looks good, could you just add description to the entity classes? |
danog
reviewed
Aug 30, 2023
| @@ -117,46 +133,46 @@ public static function markdownToMessageEntities(string $markdown): \danog\Madel | |||
| /** | |||
| * Convert a message and a set of entities to HTML. | |||
| * | |||
| * @param list<array{_: string, offset: int, length: int, ...}> $entities | |||
| * @param list<MessageEntity> $entities | |||
| * @param bool $allowTelegramTags Whether to allow telegram-specific tags like tg-spoiler, tg-emoji, mention links and so on... | |||
| */ | |||
| public static function entitiesToHtml(string $message, array $entities, bool $allowTelegramTags = false): string | |||
| { | |||
| $insertions = []; | |||
There was a problem hiding this comment.
Could you please convert the values $entities to objects if they're arrays?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Entities classes